Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Fill-Column-Indicator #194

Closed
joaotavora opened this issue Nov 3, 2011 · 5 comments
Closed

Compatibility with Fill-Column-Indicator #194

joaotavora opened this issue Nov 3, 2011 · 5 comments
Assignees

Comments

@joaotavora
Copy link
Owner

What steps will reproduce the problem?

  1. download and install the Fill-Column-Indicator addon from http://www.emacswiki.org/emacs/FillColumnIndicator
  2. run emacs and enter the fci-mode (a vertical line on the right edge of the buffer should appear)
  3. e.g. enter "time" and hit the TAB key somewhere in the middle of the buffer (just scratch buffer is sufficient)

What is the expected output? What do you see instead?
Current time should be expanded at the cursor position. But it doesn't. It's placed right after the vertical line on the same line. That's very annoying behaviour.

What version of the product are you using? On what operating system?
GNU/Linux, GNU Emacs 23.3.1, yasnippet 0.6.1 (package version 0.6.1c), Fill-Column-Indicator 1.67

Please provide any additional information below.
I don't know whether it is yasnippet's or Fill-Column-Indicator's fault. May be it's related to alpaker/fill-column-indicator#3 issue. There're some comments about improper suspending of auto-updating by yasnippet. Thanks for investigating this.

Google Code Info:
Issue #: 192
Author: wirt...@gmail.com
Created On: 2011-10-05T16:34:29.000Z
Closed On:

@ghost ghost assigned joaotavora Nov 3, 2011
@joaotavora
Copy link
Owner Author

Thanks for the heads up I had no idea this mode existed. I read the comments on the thread you provided, the author talked about fixing stuff "without yasnippet's cooperation" in July :D, but anyway I had a look and yasnippet might be abusing `inhibit-modification-hooks'.

I've fixed it but am still cautious of this change (since haven't got any automatic tests). So I've I've created a branch of yasnippet.el find it here

http://yasnippet.googlecode.com/svn/branches/TRY-better-inhibit-modification-hooks/yasnippet.el

it seems to fix it. Try it out and check back here if it works. I have to do some more testing and then I'll merge this change back to the trunk.

Google Code Info:
Author: joaotav...@gmail.com
Created On: 2011-10-06T11:48:20.000Z

@joaotavora
Copy link
Owner Author

Wow, you're fast. :-) OK, I've just downloaded the whole branch (just replacing the yasnippet.el file didn't work, there were no snippets available for expanding).

It works much better now. Thank you. :-) Actually there is still one small hitch. When I type "inc" for expanding in C++ mode, the dropdown list providing #include "..." or #include <..> choices still shows up at the wrong place (i.e. behind the vertical line). But it's not a big issue for me.

I will keep using this branch. If I discover some other problems related to this issue I'll let you know. Thanks again, great work. :-)

Google Code Info:
Author: wirt...@gmail.com
Created On: 2011-10-06T12:39:19.000Z

@joaotavora
Copy link
Owner Author

I've been using the branch all day with fci-mode without any problems :)

Google Code Info:
Author: zynode
Created On: 2011-10-06T23:22:35.000Z

@joaotavora
Copy link
Owner Author

I'll try to do some more tests then merge this back onto the trunk then.

Google Code Info:
Author: joaotav...@gmail.com
Created On: 2011-10-07T08:43:08.000Z

@joaotavora
Copy link
Owner Author

Fixed by commit c213401

joaotavora referenced this issue Jan 27, 2016
More specifically, used this and then triaged manually

git log 9733b47..f28a3df\
    --pretty=oneline | grep -E '(fix|close)'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant