Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pointer security checks to runtime support #14

Closed
zombiezen opened this issue Oct 15, 2015 · 0 comments
Closed

Add pointer security checks to runtime support #14

zombiezen opened this issue Oct 15, 2015 · 0 comments
Assignees

Comments

@zombiezen
Copy link
Contributor

Now that all pointer reads/writes can report failure, we should implement the checks detailed in Security Considerations to prevent amplification attacks and stack overflow DoS attacks.

I'm imagining this will be implemented by adding the counters to Struct and List. However, this has the side-effect that pointers to the same object from different paths will not be equal based on Go's == operator. This is mitigated because in valid Cap'n Proto messages, "no more than one pointer can point at each object", according to the spec. Because of the relatively little utility, the lack of documentation in this library around depending on this behavior, this seems reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant