Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending HTTP traffic to an RPC port panics #25

Closed
zombiezen opened this issue Apr 5, 2016 · 0 comments
Closed

Sending HTTP traffic to an RPC port panics #25

zombiezen opened this issue Apr 5, 2016 · 0 comments
Assignees
Labels

Comments

@zombiezen
Copy link
Contributor

(h/t to @bcspragu for discovering)

If you send an HTTP GET onto an RPC port, the decoder panics when trying to allocate a large header. This is much more likely to panic on GOARCH=386 or other platforms where int is 32 bits wide.

Decode should have user-configurable limits on how much it reads from the stream, but we should also prevent a high number of segments, since even the header can overflow.

@zombiezen zombiezen self-assigned this Apr 5, 2016
@zombiezen zombiezen added the bug label Apr 5, 2016
zombiezen added a commit that referenced this issue Apr 5, 2016
Addresses #25, but does not fix it entirely.  The Decoder should also
have a user-specifiable read limit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant