Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit MediaApi returning null APIs when there is no media #1117

Open
caprica opened this issue Mar 1, 2022 · 1 comment
Open

Revisit MediaApi returning null APIs when there is no media #1117

caprica opened this issue Mar 1, 2022 · 1 comment
Labels
Task
Milestone
vlcj 5.0.0 Release

Comments

@caprica
Copy link
Owner

caprica commented Mar 1, 2022

This is far from ideal and leads to unexpected NullPointerException.
@caprica caprica added the Task label Mar 1, 2022
@caprica caprica added this to the vlcj 5.0.0 Release milestone Mar 1, 2022
@caprica
Copy link
Owner Author

caprica commented Mar 1, 2022 •
edited

The point about it being null is that it forced application developers to use the API properly - invoking media API when there is no media is an application bug, it makes no sense to do that, so having the call fail in a harsh way was by design.

Maybe a bespoke exception rather than returning null would be better here.

@caprica caprica changed the title Revisit MediaApi being null when there is no media Revisit MediaApi returning null APIs when there is no media Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
vlcj 5.0.0 Release
Development

No branches or pull requests
1 participant
@caprica