Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http/2 #44

Closed
dottodot opened this issue Dec 16, 2017 · 9 comments
Closed

http/2 #44

dottodot opened this issue Dec 16, 2017 · 9 comments

Comments

@dottodot
Copy link

Is it possible to have http/2 support?

As far as I can tell nginx just needs it adding to the config such as

listen 443 ssl http2

although I might wrong and it might not be that simple.

@benjaminboruff
Copy link

... and if ssl, then redirect http as per issue #2 ?

@githubsaturn
Copy link
Collaborator

githubsaturn commented Dec 17, 2017

@dottodot
I was thinking of adding http2 as part of a bigger task: allowing user to fully customize nginx server block. That's because there won't be an end to all this kind of customizations that you can do with nginx. And, in order to keep the interface simple and concise, we want to only add the most common ones to the interface. But I'll keep this issue open to see if this is a common use case.

@benjaminboruff
Focing HTTPS is already in the pipeline. If everything goes well it'll be released before end of the year.

@ghost
Copy link

ghost commented Dec 18, 2017

I think that this app definitely need custom nginx configuration.

@githubsaturn
Copy link
Collaborator

HTTP2 and much more using fully customizable nginx config in v0.4.0

https://github.com/githubsaturn/captainduckduck/releases/tag/v0.4.0

@valoricDe
Copy link

Hi @githubsaturn does it nowadays makes sense to have http2 as default in the default nginx configuration?

@githubsaturn
Copy link
Collaborator

I don't think it'd be a good idea... It's still not the default behavior for nginx, and nginx folks probably do their research to see if it's good idea to make it default or not.

@githubsaturn
Copy link
Collaborator

Actually, here it is: https://caniuse.com/http2

3.5% of users still don't have support for http2... that's not a negligible number.

@devxpy
Copy link

devxpy commented May 16, 2023

Interesting - my default caprover installation seems to support http2
image

@devxpy
Copy link

devxpy commented May 16, 2023

Oh great its because of 60f4cdb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants