Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use class UniversignError for the errors. #12

Closed
GuillaumeLegendre opened this issue Jan 20, 2021 · 0 comments
Closed

Use class UniversignError for the errors. #12

GuillaumeLegendre opened this issue Jan 20, 2021 · 0 comments

Comments

@GuillaumeLegendre
Copy link

GuillaumeLegendre commented Jan 20, 2021 •
edited
Loading

Hello !

Would it be possible to use the class UniversignError < StandardError; end for all the errors:
https://github.com/CapSens/Universign/search?q=StandardError

Like that instead of rescue StandardError when we call the gem we could use rescue UniversignError.

It avoid to rescue an error who are not expected in the gem. In my case VCR was throwing an error on the request without cassette.

Thx a lot for the gem :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuillaumeLegendre @AntoineBecquet