Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python bindings issue on reg value for ARM64 #1929

Closed
wideglide opened this issue Oct 27, 2022 · 2 comments
Closed

python bindings issue on reg value for ARM64 #1929

wideglide opened this issue Oct 27, 2022 · 2 comments

Comments

@wideglide
Copy link
Contributor

It seems like commits 74be6d0 - f5a633d broke the python bindings in some way, but only for ARM64.

Although the disassembly text is correct the op.reg value is 0?

This is the output from bindings/python/test_arm64.py

Disasm:
0x2c:   mrs     x9, midr_el1
        op_count: 2
                operands[0].type: REG = None
                        Vector Index: 3
        Registers read: x9
        Registers modified: x9

The correct output is:

Disasm:
0x2c:   mrs     x9, midr_el1
        op_count: 2
                operands[0].type: REG = x9
                operands[0].access: READ | WRITE

                operands[1].type: SYS = 0xc000
                operands[1].access: READ | WRITE

        Registers read: x9
        Registers modified: x9
@FinnWilkinson
Copy link
Contributor

Sorry, this seems to have been overlooked in my update to Armv9.2 in #1907 ! I’ll look into adding the new bindings asap

@wideglide
Copy link
Contributor Author

awesome, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants