Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.x release suggestions #2081

Closed
17 of 24 tasks
XVilka opened this issue Jul 10, 2023 · 25 comments
Closed
17 of 24 tasks

5.0.x release suggestions #2081

XVilka opened this issue Jul 10, 2023 · 25 comments

Comments

@XVilka
Copy link
Contributor

XVilka commented Jul 10, 2023

Would be nice to have fixes for these in the patch release:

5.0.1

5.0.2

After they are fixed in the next branch, fixes could be cherry-picked to the v5 branch one by one for the release.

@XVilka
Copy link
Contributor Author

XVilka commented Jul 11, 2023

There are also many PPC regressions found by @wargio but they will be fixed in the #2013 so it doesn't make sense trying to fix them in the patch release.

XVilka referenced this issue in qemu/qemu Jul 11, 2023
this are the changes from volumit
(https://github.com/volumit/qemu/commits/master) compacted into one
patch.

Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
@kabeor kabeor pinned this issue Jul 21, 2023
@XVilka
Copy link
Contributor Author

XVilka commented Jul 21, 2023

@kabeor you need to cherry-pick corresponding commits from next to v5: https://github.com/capstone-engine/capstone/tree/v5

@kabeor
Copy link
Member

kabeor commented Jul 21, 2023

Well looks like there are some misunderstood. v5 should merge something only if we are ready to release a version. so I think we needn't cherry-pick.

@XVilka
Copy link
Contributor Author

XVilka commented Jul 21, 2023

@kabeor but you already cherry-picked some of these fixes - SH and ARM VFP fix. Idea is to cherry-pick these fixes and tag 5.0.1

@kabeor
Copy link
Member

kabeor commented Jul 21, 2023

@XVilka Aha @aquynh did this. I should talk with him about this tmw😂

@XVilka
Copy link
Contributor Author

XVilka commented Jul 25, 2023

Looks like only x86 regression and deprecated modules left in this list, the rest was merged

@wargio
Copy link

wargio commented Jul 25, 2023

also the ppc regressions

@XVilka
Copy link
Contributor Author

XVilka commented Jul 25, 2023

@wargio there are way too many, not sure if it makes sense to devote time instead of investing time in auto-sync PPC

@Rot127
Copy link
Collaborator

Rot127 commented Jul 25, 2023

@kabeor Could we add a note to the 5.0.1 release, that the v6 release will bring some big changes (possibly linking to #2124)? In this case people have the chance to decide if they might want to skip v5 altogether.

@kabeor
Copy link
Member

kabeor commented Jul 26, 2023

@Rot127 ok, it's a perfect time to announce that.

@Rot127
Copy link
Collaborator

Rot127 commented Jul 26, 2023

@kabeor Great! You can link to the WIP release text here or to the PR.

@Rot127
Copy link
Collaborator

Rot127 commented Jul 26, 2023

@kabeor Could you please also a line that everyone is welcome to give early feedback regarding v6. The whole auto-sync thing still misses more eyes from the outside. And new releases have definitely more impact than issues.

@XVilka
Copy link
Contributor Author

XVilka commented Aug 4, 2023

@kabeor @aquynh I suggest to cherry-pick already existing fixes and tag 5.0.1
Not everything was fixed but some most annoying things were fixed already - the rest could land in 5.0.2 or something like that.

@XVilka

This comment was marked as resolved.

1 similar comment
@XVilka

This comment was marked as resolved.

@kabeor
Copy link
Member

kabeor commented Aug 21, 2023

#2141

@XVilka XVilka changed the title 5.0.1 release suggestions 5.0.x release suggestions Aug 21, 2023
@XVilka
Copy link
Contributor Author

XVilka commented Aug 21, 2023

Thank you, @kabeor!

@XVilka
Copy link
Contributor Author

XVilka commented Aug 23, 2023

@kabeor looks like some assets missing from the release?

@kabeor
Copy link
Member

kabeor commented Aug 23, 2023

@XVilka I see. Reference to Docs: Workflows are not triggered for the created, edited, or deleted activity types for draft releases.. Maybe published field will fix this. Will test on next release.

@XVilka
Copy link
Contributor Author

XVilka commented Aug 24, 2023

@gerph added your issues here. Worth carving a quick 5.0.2 bugfix release when fixes are available.

@gerph
Copy link

gerph commented Aug 24, 2023

@gerph added your issues here. Worth carving a quick 5.0.2 bugfix release when fixes are available.

Thanks :-)

There's no ticket for it, but it probably should apply to all the releases... a reminder to update the cs_version so that each release could be differentiated, would be good.

@Rot127
Copy link
Collaborator

Rot127 commented Oct 21, 2023

@XVilka Could you add #2177 and #2174 to the list?

@No-47
Copy link

No-47 commented Oct 23, 2023

@XVilka
This small problem can also be fixed issues:
#2177

@XVilka
Copy link
Contributor Author

XVilka commented Jan 21, 2024

@kabeor for 5.0.2 please cherry-pick #2221 then.

@Rot127
Copy link
Collaborator

Rot127 commented Mar 20, 2024

Close this because we now track issues with milestones, see: https://github.com/capstone-engine/capstone/milestone/4

@Rot127 Rot127 closed this as completed Mar 20, 2024
@Rot127 Rot127 unpinned this issue Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants