Skip to content

Commit

Permalink
Fixed problem including the config file in Sublime
Browse files Browse the repository at this point in the history
Also fixed small problem when syntax error
  • Loading branch information
Patrick Brosset committed Feb 13, 2012
1 parent 0f19044 commit f4e1fac
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 3 deletions.
6 changes: 5 additions & 1 deletion cleanjs_cmdline.py
Expand Up @@ -27,7 +27,11 @@


# Gather data about the file to be reviewed # Gather data about the file to be reviewed
from parsers import fileparser from parsers import fileparser
file_data = fileparser.get_file_data_from_file(file_name) try:
file_data = fileparser.get_file_data_from_file(file_name)
except Exception as error:
print error
exit()


# Review the file # Review the file
from reviewers import reviewer from reviewers import reviewer
Expand Down
2 changes: 1 addition & 1 deletion parsers/jsparser.py
Expand Up @@ -83,7 +83,7 @@ def visit(self):
self._walk_node() self._walk_node()
self.exec_postprocess_visitors(self.source) self.exec_postprocess_visitors(self.source)
else: else:
raise self.parser.error raise self.parser.parsing_error


def _look_for_childen(self, node): def _look_for_childen(self, node):
for attr in self.CHILD_ATTRS: for attr in self.CHILD_ATTRS:
Expand Down
9 changes: 8 additions & 1 deletion reviewers/reviewer.py
Expand Up @@ -4,10 +4,17 @@
from messagebag import MessageBag from messagebag import MessageBag
from config.reader import ReviewerConfigReader from config.reader import ReviewerConfigReader


def _get_config_file_path():
root_dir = os.getcwd()
if root_dir[-7:] != "cleanjs" and root_dir[-8:] != "cleanjs" + os.sep:
root_dir = root_dir + os.sep + "cleanjs"

return root_dir + os.sep + "reviewers" + os.sep + "config" + os.sep + "messages.cfg"

def review(file_data): def review(file_data):
"""Takes in a FileData instance, runs all reviewers on it, and returns a reviewers.reviewer.ReviewedFile instance""" """Takes in a FileData instance, runs all reviewers on it, and returns a reviewers.reviewer.ReviewedFile instance"""


config_reader = ReviewerConfigReader("reviewers" + os.sep + "config" + os.sep + "messages.cfg") config_reader = ReviewerConfigReader(_get_config_file_path())


message_bag = MessageBag() message_bag = MessageBag()


Expand Down

0 comments on commit f4e1fac

Please sign in to comment.