Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the Firefox DevTools dark theme. #9

Open
captainbrosset opened this issue Dec 7, 2017 · 2 comments
Open

Support the Firefox DevTools dark theme. #9

captainbrosset opened this issue Dec 7, 2017 · 2 comments

Comments

@captainbrosset
Copy link
Owner

captainbrosset commented Dec 7, 2017

Firefox DevTools supports 2 themes (well 3 if you count the Firebug theme, but it's similar to the light theme).
The extension currently looks good when DevTools is set to the light theme. If you switch DevTools to the dark theme however, then things look pretty bad and some things become harder to read.

@captainbrosset captainbrosset changed the title Support the dark theme. Support the Firefox DevTools dark theme. Dec 22, 2017
@captainbrosset
Copy link
Owner Author

Light theme:
screen shot 2017-12-22 at 11 56 38

Dark theme:
screen shot 2017-12-22 at 11 56 50

Several issues:

  • the tab icon stays black, which means it's not visible anymore
  • the toolbar (with the search field) stays white, which means it doesn't go well with the rest of the Dark theme
  • the HTML syntax highlight colors don't work well anymore (<, >, = and " are black on black, and other colors aren't contrasted enough)
  • the hover background that appears when hovering over results isn't visible anymore.

@captainbrosset
Copy link
Owner Author

Looks like there is a web extension API that helps with theme support :

browser.devtools.panels.themeName // theme
// event listener
browser.devtools.panels.onThemeChanged.addListener(theme => {});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant