Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No name shown in 'replying to' section of post when using Mitra #75

Open
1 of 4 tasks
watamelonman opened this issue May 21, 2024 · 10 comments
Open
1 of 4 tasks
Labels
bug Something isn't working

Comments

@watamelonman
Copy link

watamelonman commented May 21, 2024

General description of the issue

When using Husky with an account on a Mitra instance, replies do not show the target of said reply. There is only blank space next to the 'replying to' section. This blank space happens on all posts regardless of origin (e.g. whether it's from a Pleroma instance, Mastodon, Misskey, Mitra, etc.). This isn't a problem when viewing the same posts from Mitra's web UI.
Screenshot_20240521-114353

Husky information

  • Husky version: 1.5.4
  • Android version: 14
  • Android ROM version: CalyxOS 5.7.0

Mitra version of instance

  • Mitra v2.18

Steps to reproduce it

Please, describe the steps to reproduce the issue:

  1. Log into Mitra instance account on Husky
  2. View any post that is a reply

Where did you get Husky from:

  • F-Droid.
  • Self-releases.
  • Play Store.
  • Self-compiled (specify tag/commit).
@watamelonman watamelonman added the bug Something isn't working label May 21, 2024
@watamelonman watamelonman changed the title No name shown in 'replying to' section of post when using Mitda No name shown in 'replying to' section of post when using Mitra May 21, 2024
@captainepoch
Copy link
Owner

If Mitra implements the ActivityPub API as Pleroma or Mastodon does, it should show it. I'll take a look, but it's probably not Husky's fault.

@silverpill
Copy link

@captainepoch Sure, looks like a problem is on the Mitra side. Could you tell where data for this UI element comes from?
I'd expect it to be Status.in_reply_to_id or Status.in_reply_to_account_id, but Mitra provides both, so it must be something else?

@captainepoch
Copy link
Owner

If it provides any of those (but I think the correct one is in_reply_to_account_id), it should show.

Nevertheless, I still have my account in your Mitra instance, so I'll take a look.

@captainepoch
Copy link
Owner

As far as I can see, in_reply_to_account_id is null (see attached image).

Captura de Pantalla 2024-05-28 a las 20 20 49

@silverpill
Copy link

Yes, but on this image in_reply_to_id is also null, so it is probably not a reply?

@captainepoch
Copy link
Owner

You're right about that, I made the screenshot about the wrong value. It is, indeed, with information about the account.

It seems, in the end, a Husky issue, so I'll do more research on why this is happening.

Captura de Pantalla 2024-05-28 a las 22 27 16

@captainepoch
Copy link
Owner

I didn't forget about this, I'm still investigating why it's happening.

@captainepoch
Copy link
Owner

Hello!

I finally detected what's the issue is here.

Pleroma and Mastodon (I globalize also their forks) include the username in the reply's response Json by the field in_reply_to_account_acct. If the user is at the same instance, it doesn't show the @stereophonic.space (as an example), and if it's not at the same instance, it does (see screenshots attached).

Mitra should do the same.
Captura de Pantalla 2024-07-10 a las 19 38 49

Captura de Pantalla 2024-07-10 a las 19 39 20

@silverpill
Copy link

I haven't found this field in Mastodon responses, but Pleroma includes pleroma.in_reply_to_account_acct and I added it too.
@watamelonman said that fixed the problem, so we can close the issue now.

Thank you!

@captainepoch
Copy link
Owner

You're totally right about this, and it happens on Mastodon instances using Husky, thank you very much for noticing it.

I'll try to come up with a fix, in case you want to remove this fied, so it works for both of the backends.

Again, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants