New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace loading.gif with text (maybe with css animation) #119
Comments
I think going with a css option is great, had a look around and saw cool things for 3k and less. |
The loading png had two problems. One was that it was stupidly huge (my bad!), the second was that the project loads too fast to use an external resource effectively. On my home internet (which is probably faster than some), the site loads in ~.8 seconds and images in the css file are not being requested until about a third of the way through that. Even if the loading.gif loads instantly (which it didn't when it was huge) that leaves ~500ms for the animation to actually play. For me, even the static text is essentially invisible. I suppose the loading animation would probably be for people who's internet is much slower, but if a ~178KB site loads so slowly for you that you need an animated gif to amuse you, even a ~7KB loading gif might feel heavy. Disagree? As for the optimized skin, you've made me realize I'm making a non-optimal technical choice for emotional reasons... but I don't think I'll change 😄 Part of what makes this project feel so cool to me is being able to say (and know) that "we use the original Winamp skin assets". I know that's not 100% true. We tweaked that one file with the strange encoding issue, and the original skin files are not actually distributed in a zip file. Still, when I look at the app, my brain says "I'm looking at same bits I looked at as a kid". Obviously they would render exactly the same from .png files and the output would be identical, but for some emotional reason, I have to object. All this talk of premature optimization (which I know is a sin, but I secretly love) made me realize that we could also save a bunch of space by removing the skin asset files we are not yet using. Even with the original bmp files, a quick test shows we could bring the file size down to 45KB. But again, for illogical, emotional reasons, that doesn't feel right to me. Hmmmmmmmmmmm. |
Doing things for emotional reasons is something Im all for. :) Ive only recently got off dialup (im sooooo poor) and a 25k file, bad, an 8k file, meh, -3k css (less with gzip stuff), good. By the way that 89.1k zip file is your zip file with the skinningsomething.txt file taken out and optimized. The optimizer can turn the normal zip from 100,127 bytes to 92,117 and 91,282 if you take out that skinning.txt file...every byte counts. And I love premature optimizing, it gives me something to do when Im not up for coding. |
1 Ive got to use those tools more ;) |
Actually I just checked what the last thing I did in grunt was jonschlinkert/sublime-monokai-extended#35 and I ended up using handlebars to insert stuff...hehe, my memory really is shocking! :) |
To comment on loading and internet speeds: I currently live in a third world country where most people access the internet via mobile devices. To assume your loading speed is a good benchmark might be folly, because there's an entire world of people who don't experience the internet as fast as you do. |
@Akamaozu Thanks for adding that perspective. Regarding the loading animation, it feels odd to help people with a slow connection by making the total download size larger. Maybe we could add a simple css animation to the "Loading..." text to give the impression that progress is being made. I think it's worth considering that there are actually three problems here:
@Akamaozu Which of these do you think is most important for people in your area? |
Also worth noting: The notoriously minimal Google home page is ~350KB, and we are offering a much more elaborate app in half that size. Edit: Err.. I'm not claiming winamp2-js is more elaborate than the Google search engine. LOL. |
loading.gif
is 23.5KB, which is 15% of our total payload. That seems kinda dumb. I think we load quickly enough that we should just have a text loading message.The text was updated successfully, but these errors were encountered: