Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equalizer Window: ON Button has the wrong dimension (2 pixels too wide) #1190

Open
dettus opened this issue Nov 21, 2022 · 3 comments
Open

Comments

@dettus
Copy link

dettus commented Nov 21, 2022

Hello!

So, I took the liberty of uploading this theme the other day...

https://skins.webamp.org/skin/75a086cef75b26371b184d28b9150860/d11amp059_theme.wsz/

Here, you will notice that the ON button is active, but at least one pixel of the AUTO button is illuminated as well.
So, at first, I suspected the theme to have a bug, but when I loaded this theme

https://skins.webamp.org/skin/47597ab8e5ffcd39686d455c10c3b436/Garfield.zip/

I saw the same effect of the ON button bleeding over into the AUTO button. (Albeit only being visible with the pressed Button)
I have not yet checked it against XMMS or WinAmp yet. Sorry.

@0x5066
Copy link
Contributor

0x5066 commented Nov 21, 2022

Confirmed, WACUP and Winamp 5.666 both display the skin correctly, whereas Webamp does not.
winamp original_g5SYNoK731

Interestingly enough I already took care of rendering it properly myself in my own classic skin framework, without even knowing. :p
winamp original_Rwkx6HTeFq

@dettus
Copy link
Author

dettus commented Nov 22, 2022

AAAAND apparently your classic skin framework has a bug as well... The numbers are not the ones from the skin ;)

@0x5066
Copy link
Contributor

0x5066 commented Nov 22, 2022

Modern Skin issue, honestly :)
Can't reuse the numbers.bmp properly, and there's some other caveats as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants