Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global css from DOM when Webamp is unmouted #736

Open
captbaritone opened this issue Mar 4, 2019 · 0 comments
Open

Remove global css from DOM when Webamp is unmouted #736

captbaritone opened this issue Mar 4, 2019 · 0 comments

Comments

@captbaritone
Copy link
Owner

Generally, we need to find a better way to include css.

  • It’s the main blocker still stopping us from dropping Webpack from the NPM build, and thus the only thing stopping us from shipping a non-bundled version. This would let people reuse the version of React which is already on their page.
  • CSS should be removed from the DOM when the component is unmonted.
  • If there are multiple versions of Webamp on a page, we should only add on set of global CSS to the DOM. Maybe some kind of global variable that holds a reference count?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant