Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tests #13

Merged
merged 10 commits into from Jul 4, 2021
Merged

Add Tests #13

merged 10 commits into from Jul 4, 2021

Conversation

captn3m0
Copy link
Owner

@captn3m0 captn3m0 commented Jul 3, 2021 •
edited

Starting Integration tests. Currently tracks:

  • Sticher functionality by generating all test files
  • Number of pages in these test files
  • Bookmarks (title/destination page number)
  • Bookmark level
  • PDF metadata
  • Attributes: Rotation
  • Attributes: Page Selection
  • Run CI tests on GitHub Actions
  • Generate coverage reports

Missing testcases:

  • Remote fetching (Will take this up later)
  • Custom Title
  • H2/H3 as bookmarks
  • Disable cleanup and validate

@captn3m0 captn3m0 requested a review from Vonter July 3, 2021 20:21
@captn3m0 captn3m0 self-assigned this Jul 3, 2021
@captn3m0 captn3m0 added the enhancement New feature or request label Jul 3, 2021
@captn3m0 captn3m0 mentioned this pull request Jul 3, 2021
Open
@captn3m0
[tests] Adds tests for rotated pages
7b50168
@captn3m0
[tests] Add tests for page-selection
5bda809 
Changed the page-select file to keep older bookmarks
since we need to test for some bookmarks being stripped
@captn3m0 captn3m0 changed the title Adds initial tests Add Tests Jul 3, 2021
@captn3m0 captn3m0 force-pushed the initial-tests branch 2 times, most recently from 5b21ea6 to 1127720 Compare July 3, 2021 21:37
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2021 •
edited by codecov bot

Codecov Report

❗ No coverage uploaded for pull request base (main@af4752b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage        ?   93.90%           
=======================================
  Files           ?        5           
  Lines           ?      246           
  Branches        ?       34           
=======================================
  Hits            ?      231           
  Misses          ?       11           
  Partials        ?        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af4752b...8c24241. Read the comment docs.

Vonter
Vonter approved these changes Jul 4, 2021
View reviewed changes
Copy link
Collaborator

@Vonter Vonter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for taking this up 👍

@captn3m0 captn3m0 merged commit cc2a58b into main Jul 4, 2021
@captn3m0 captn3m0 deleted the initial-tests branch July 4, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vonter Vonter Vonter approved these changes

Assignees

@captn3m0 captn3m0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@captn3m0 @codecov-commenter @Vonter