/
experiment_service.go
518 lines (457 loc) · 15.6 KB
/
experiment_service.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
package service
import (
"encoding/json"
"errors"
"fmt"
"time"
"github.com/patrickmn/go-cache"
"github.com/caraml-dev/turing/api/turing/config"
logger "github.com/caraml-dev/turing/api/turing/log"
"github.com/caraml-dev/turing/engines/experiment"
"github.com/caraml-dev/turing/engines/experiment/manager"
"github.com/caraml-dev/turing/engines/experiment/pkg/request"
)
const (
expCacheExpirySeconds = 600
expCacheCleanUpSeconds = 900
)
// ExperimentsService provides functionality to work with experiment engines
// supported by Turing
type ExperimentsService interface {
// IsStandardExperimentManager checks if the experiment manager is of the standard type
IsStandardExperimentManager(engine string) bool
// IsClientSelectionEnabled checks if the experiment manager is of the standard type and
// has clients
IsClientSelectionEnabled(engine string) (bool, error)
// ListEngines returns a list of the experiment engines available
ListEngines() []manager.Engine
// ListClients returns a list of the clients registered on the given experiment engine
ListClients(engine string) ([]manager.Client, error)
// ListExperiments returns a list of the experiments registered on the given experiment engine,
// and for the given clientID if supplied
ListExperiments(engine string, clientID string) ([]manager.Experiment, error)
// ListVariables returns a list of the variables registered on the given experiment engine,
// for the given clientID and/or experiments
ListVariables(engine string, clientID string, experimentIDs []string) (manager.Variables, error)
// ValidateExperimentConfig validates the given experiment config for completeness
ValidateExperimentConfig(engine string, cfg json.RawMessage) error
// GetExperimentRunnerConfig converts the given experiment config compatible with the Experiment Manager
// into the format compatible with the ExperimentRunner
GetExperimentRunnerConfig(engine string, cfg json.RawMessage) (json.RawMessage, error)
}
type experimentsService struct {
// map of engine name -> Experiment Manager
experimentManagers map[string]manager.ExperimentManager
cache *cache.Cache
}
// Experiment represents an experiment in Turing. The experiment info can come from different experiment engines.
type Experiment struct {
ID string `json:"id"`
Name string `json:"name"`
ClientName string `json:"client_name"`
UnitType string `json:"unit_type"`
Treatments []string `json:"treatments"` // List of treatment names (i.e. variations) in the experiment.
}
// NewExperimentsService creates a new experiment service from managerConfig.
// managerConfig is a map of experiment manager name to the JSON string configuration.
func NewExperimentsService(managerConfig map[string]config.EngineConfig) (ExperimentsService, error) {
experimentManagers := make(map[string]manager.ExperimentManager)
for name, engineConfig := range managerConfig {
factory, err := experiment.NewEngineFactory(name, engineConfig, logger.Glob())
if err != nil {
return nil, err
}
m, err := factory.GetExperimentManager()
if err != nil {
return nil, err
}
experimentManagers[name] = m
}
// Initialize the experimentsService with cache
svc := &experimentsService{
experimentManagers: experimentManagers,
cache: cache.New(expCacheExpirySeconds*time.Second, expCacheCleanUpSeconds*time.Second),
}
// Populate the cache with the Clients / Experiments info from Standard Engines
for expEngine, expManager := range svc.experimentManagers {
engineInfo, err := expManager.GetEngineInfo()
if err != nil {
logger.Warnf("failed to retrieve info for engine %s: %v", expEngine, err)
continue
}
if engineInfo.Type == manager.StandardExperimentManagerType {
if engineInfo.StandardExperimentManagerConfig == nil {
return nil, fmt.Errorf("Standard Experiment Manager config missing for engine %s", expEngine)
}
if engineInfo.StandardExperimentManagerConfig.ClientSelectionEnabled {
_, err := svc.ListClients(expEngine)
if err != nil {
return nil, err
}
} else if engineInfo.StandardExperimentManagerConfig.ExperimentSelectionEnabled {
_, err := svc.ListExperiments(expEngine, "")
if err != nil {
return nil, err
}
}
}
}
return svc, nil
}
func (es *experimentsService) IsStandardExperimentManager(engine string) bool {
expManager, err := es.getExperimentManager(engine)
if err != nil {
return false
}
return manager.IsStandardExperimentManager(expManager)
}
func (es *experimentsService) IsClientSelectionEnabled(engine string) (bool, error) {
expManager, err := es.getExperimentManager(engine)
if err != nil {
return false, err
}
engineInfo, err := expManager.GetEngineInfo()
if err != nil {
return false, err
}
return manager.IsStandardExperimentManager(expManager) &&
engineInfo.StandardExperimentManagerConfig != nil &&
engineInfo.StandardExperimentManagerConfig.ClientSelectionEnabled, nil
}
func (es *experimentsService) ListEngines() []manager.Engine {
engines := []manager.Engine{}
for _, expManager := range es.experimentManagers {
engineInfo, err := expManager.GetEngineInfo()
if err == nil {
engines = append(engines, engineInfo)
}
}
return engines
}
func (es *experimentsService) ListClients(engine string) ([]manager.Client, error) {
return es.listClientsWithCache(engine)
}
func (es *experimentsService) ListExperiments(
engine string,
clientID string,
) ([]manager.Experiment, error) {
// Get client, if the clientID has been supplied
var client *manager.Client
var err error
if clientID != "" {
client, err = es.getClientWithCache(engine, clientID)
if err != nil {
return []manager.Experiment{}, err
}
}
return es.listExperimentsWithCache(engine, client)
}
func (es *experimentsService) ListVariables(
engine string,
clientID string,
experimentIDs []string,
) (manager.Variables, error) {
var variables manager.Variables
var err error
// Get client and its variables, if the clientID has been supplied
var client *manager.Client
clientVariables := []manager.Variable{}
if clientID != "" {
client, err = es.getClientWithCache(engine, clientID)
if err != nil {
return variables, err
}
clientVariables, err = es.listClientVariablesWithCache(engine, client)
if err != nil {
return variables, err
}
}
// Get experiments and their variables, if experiment ids have been supplied
var experiments []manager.Experiment
experimentVariables := make(map[string][]manager.Variable)
if len(experimentIDs) > 0 {
experiments, err = es.getExperimentsWithCache(engine, client, experimentIDs)
if err != nil {
return variables, err
}
experimentVariables, err = es.listExperimentVariablesWithCache(engine, experiments)
if err != nil {
return variables, err
}
}
// Reconcile variables for configuration
variableConfigs := reconcileVariables(clientVariables, experimentVariables)
// Return variables info
return manager.Variables{
ClientVariables: clientVariables,
ExperimentVariables: experimentVariables,
Config: variableConfigs,
}, nil
}
func (es *experimentsService) ValidateExperimentConfig(engine string, cfg json.RawMessage) error {
// Get experiment manager
expManager, err := es.getExperimentManager(engine)
if err != nil {
return err
}
return expManager.ValidateExperimentConfig(cfg)
}
func (es *experimentsService) GetExperimentRunnerConfig(engine string, cfg json.RawMessage) (json.RawMessage, error) {
// Get experiment manager
expManager, err := es.getExperimentManager(engine)
if err != nil {
return json.RawMessage{}, err
}
return expManager.GetExperimentRunnerConfig(cfg)
}
func (es *experimentsService) getExperimentManager(
engine string,
) (manager.ExperimentManager, error) {
expManager, ok := es.experimentManagers[engine]
if !ok {
return nil, fmt.Errorf("Unknown experiment engine %s", engine)
}
return expManager, nil
}
func (es *experimentsService) listClientsWithCache(engine string) ([]manager.Client, error) {
// Get experiment manager
expManager, err := es.getExperimentManager(engine)
if err != nil {
return []manager.Client{}, err
}
cacheKey := fmt.Sprintf("engine:%s:clients", engine)
cacheEnabled := manager.IsCacheEnabled(expManager)
if cacheEnabled {
// Attempt to retrieve info from cache
cachedValue, found := es.cache.Get(cacheKey)
// Found in cache - cast the data and return
if found {
clients, ok := cachedValue.([]manager.Client)
if !ok {
return []manager.Client{},
fmt.Errorf("Malformed clients info found in the cache for engine %s", engine)
}
return clients, nil
}
}
// Cache disabled / not found in cache - invoke API
clients, err := manager.ListClients(expManager)
if err != nil {
return []manager.Client{}, err
}
if cacheEnabled {
es.cache.Set(cacheKey, clients, cache.DefaultExpiration)
}
return clients, nil
}
func (es *experimentsService) listExperimentsWithCache(
engine string,
client *manager.Client,
) ([]manager.Experiment, error) {
// Get experiment manager
expManager, err := es.getExperimentManager(engine)
if err != nil {
return []manager.Experiment{}, err
}
var cacheKey string
var listExperimentsMethod func() ([]manager.Experiment, error)
cacheEnabled := manager.IsCacheEnabled(expManager)
// Set cache key and API method to be called, based on client info passed in
if client != nil {
cacheKey = fmt.Sprintf("engine:%s:clients:%s:experiments", engine, client.ID)
listExperimentsMethod = func() ([]manager.Experiment, error) {
return manager.ListExperimentsForClient(expManager, *client)
}
} else {
cacheKey = fmt.Sprintf("engine:%s:experiments", engine)
listExperimentsMethod = func() ([]manager.Experiment, error) {
return manager.ListExperiments(expManager)
}
}
if cacheEnabled {
// Attempt to retrieve info from cache
cachedValue, found := es.cache.Get(cacheKey)
// Found in cache - cast the data and return
if found {
experiments, ok := cachedValue.([]manager.Experiment)
if !ok {
return []manager.Experiment{},
errors.New("Malformed experiments info found in the cache")
}
return experiments, nil
}
}
// Cache disabled / not found in cache - invoke Experiment Manager API
experiments, err := listExperimentsMethod()
if err != nil {
return []manager.Experiment{}, err
}
if cacheEnabled {
es.cache.Set(cacheKey, experiments, cache.DefaultExpiration)
}
return experiments, nil
}
func (es *experimentsService) listClientVariablesWithCache(
engine string,
client *manager.Client,
) ([]manager.Variable, error) {
// Get experiment manager
expManager, err := es.getExperimentManager(engine)
if err != nil {
return []manager.Variable{}, err
}
cacheKey := fmt.Sprintf("engine:%s:clients:%s:variables", engine, client.ID)
cacheEnabled := manager.IsCacheEnabled(expManager)
if cacheEnabled {
// Attempt to retrieve info from cache
cachedValue, found := es.cache.Get(cacheKey)
// Found in cache - cast the data and return
if found {
variables, ok := cachedValue.([]manager.Variable)
if !ok {
return []manager.Variable{},
fmt.Errorf("Malformed variables info found in the cache for client %s", client.ID)
}
return variables, nil
}
}
// Cache disabled / not found in cache - invoke API
variables, err := manager.ListVariablesForClient(expManager, *client)
if err != nil {
return []manager.Variable{}, err
}
if cacheEnabled {
es.cache.Set(cacheKey, variables, cache.DefaultExpiration)
}
return variables, nil
}
func (es *experimentsService) listExperimentVariablesWithCache(
engine string,
experiments []manager.Experiment,
) (map[string][]manager.Variable, error) {
// Get experiment manager
expManager, err := es.getExperimentManager(engine)
if err != nil {
return map[string][]manager.Variable{}, err
}
cacheEnabled := manager.IsCacheEnabled(expManager)
// Store variables for each experiment (experiment_id -> variables map)
expVariables := map[string][]manager.Variable{}
// Save the experiments whose variables need to be queried
filteredExperiments := []manager.Experiment{}
if cacheEnabled {
// For each experiment, attempt to retrieve variables from cache
for _, exp := range experiments {
cacheKey := fmt.Sprintf("engine:%s:experiments:%s:variables", engine, exp.ID)
cachedValue, found := es.cache.Get(cacheKey)
if found {
variables, ok := cachedValue.([]manager.Variable)
if !ok {
return expVariables,
fmt.Errorf("Malformed variables info found in the cache for experiment %s", exp.ID)
}
expVariables[exp.ID] = variables
} else {
// If not exists, add experiment to filteredExperiments, for querying from API
filteredExperiments = append(filteredExperiments, exp)
}
}
} else {
// Cache disabled, query for all experiments
filteredExperiments = experiments
}
// Get variables for filteredExperiments which could be an empty list if we got everything
// from the cache
filteredExpVariables, err := manager.ListVariablesForExperiments(expManager, filteredExperiments)
if err != nil {
return expVariables, err
}
// Merge filteredExpVariables and expVariables, saving to cache, and return
for id, vars := range filteredExpVariables {
expVariables[id] = vars
if cacheEnabled {
cacheKey := fmt.Sprintf("engine:%s:experiments:%s:variables", engine, id)
es.cache.Set(cacheKey, vars, cache.DefaultExpiration)
}
}
return expVariables, nil
}
func (es *experimentsService) getClientWithCache(
engine string,
clientID string,
) (*manager.Client, error) {
// Get all clients for the engine
clients, err := es.listClientsWithCache(engine)
if err != nil {
return nil, err
}
// Filter clients by ID
for _, c := range clients {
if c.ID == clientID {
return &c, nil
}
}
return nil, fmt.Errorf("Could not find client with ID %s", clientID)
}
func (es *experimentsService) getExperimentsWithCache(
engine string,
client *manager.Client,
experimentIDs []string,
) ([]manager.Experiment, error) {
// Get all experiments (for the client, if supplied)
experiments, err := es.listExperimentsWithCache(engine, client)
if err != nil {
return nil, err
}
// Filter the experiments whose ids are given in experimentIDs
expIDMap := make(map[string]manager.Experiment)
for _, e := range experiments {
expIDMap[e.ID] = e
}
var filteredExperiments []manager.Experiment
for _, eID := range experimentIDs {
if e, found := expIDMap[eID]; found {
filteredExperiments = append(filteredExperiments, e)
} else {
return []manager.Experiment{}, fmt.Errorf("Could not find experiment %s", eID)
}
}
return filteredExperiments, nil
}
func reconcileVariables(
clientVariables []manager.Variable,
experimentVariables map[string][]manager.Variable,
) []manager.VariableConfig {
varCfgMap := map[string]manager.VariableConfig{}
reconcileFunc := func(item manager.Variable) {
// Assume that variables are case-sensitive and can be uniquely identified by name
if cfg, found := varCfgMap[item.Name]; found {
// If a variable is required for any of the experiments / client, it should be required
// for the overall Turing experiment
cfg.Required = cfg.Required || item.Required
varCfgMap[item.Name] = cfg
} else {
varCfgMap[item.Name] = manager.VariableConfig{
Name: item.Name,
Required: item.Required,
// Set header field source by default
FieldSource: request.HeaderFieldSource,
}
}
}
// Process client variables and experiment variables
for _, v := range clientVariables {
reconcileFunc(v)
}
for _, vars := range experimentVariables {
for _, v := range vars {
reconcileFunc(v)
}
}
// Convert map to list and return
variableConfigs := []manager.VariableConfig{}
for _, item := range varCfgMap {
variableConfigs = append(variableConfigs, item)
}
return variableConfigs
}