Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readability: use std::stack in lieu of Cons #286

Closed
dabrahams opened this issue Feb 23, 2021 · 3 comments
Closed

Readability: use std::stack in lieu of Cons #286

dabrahams opened this issue Feb 23, 2021 · 3 comments
Labels
explorer Action items related to Carbon explorer code

Comments

@dabrahams
Copy link

Per @jsiek. It will help readability to see the words stack, push, and pop in the code where that's the actual abstraction at work.

@dabrahams dabrahams added the explorer Action items related to Carbon explorer code label Feb 23, 2021
@dabrahams dabrahams self-assigned this Feb 23, 2021
@jsiek
Copy link
Contributor

jsiek commented Mar 3, 2021

To update this issue. Some uses of Cons were replaced by a new Stack class. The next step is to replace the Stack class with uses of std::stack.

@dabrahams
Copy link
Author

I am not yet convinced using std::stack is a good move. See the last part of #327 (comment) for details.

@jonmeow
Copy link
Contributor

jonmeow commented Aug 13, 2021

I think the Stack switch is the direction we're going, I'm considering this resolved.

@jonmeow jonmeow closed this as completed Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
explorer Action items related to Carbon explorer code
Projects
None yet
Development

No branches or pull requests

3 participants