Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setMinValue and setMaxValue bug #51

Open
ErgooLee opened this issue Aug 7, 2018 · 1 comment
Open

setMinValue and setMaxValue bug #51

ErgooLee opened this issue Aug 7, 2018 · 1 comment

Comments

@ErgooLee
Copy link

ErgooLee commented Aug 7, 2018

in demo ActivityTimePicker
line 65:
replace
setData(mPickerViewH, 0, 11, h);
with
setData(mPickerViewH, 3, 4, 4);

hour picker show 1 and 12
NOT 3 and 4

I think it's a bug.
if setMinValue is not 0, number picker view will not work.

@ErgooLee
Copy link
Author

ErgooLee commented Aug 7, 2018

in NumberPickerView line 723, setMinValue(int minValue) method
public void setMinValue(int minValue){
mMinValue = minValue;
mMinShowIndex = 0;
updateNotWrapYLimit();
}

I think it should be like this:
public void setMinValue(int minValue){
mMinValue = minValue;
mMinShowIndex = minValue;
updateNotWrapYLimit();
}
and it worked well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant