Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong name "Hash32HexString" #271

Closed
SebastienGllmt opened this issue Aug 2, 2020 · 1 comment · Fixed by #342
Closed

Wrong name "Hash32HexString" #271

SebastienGllmt opened this issue Aug 2, 2020 · 1 comment · Fixed by #342
Assignees
Milestone

Comments

@SebastienGllmt
Copy link

The name Hash32HexString shows up in many places despite many of these hashes actually being hash28. Presumably this was caused by many of these hashes previously being 32 until some of them were changed to 28 in the binary spec. Since some hashes are 28 and some hashes are 32, it may be simpler to just rename this to not include the length in the name (or you can create a "Hash28" type)

@rhyslbw
Copy link
Contributor

rhyslbw commented Aug 11, 2020

Yes the opportunity to generalise the label of this scalar to Hash was missed at the 2.0.0 release. We'll consider the best approach to correct this once CIP5 lands.

@rhyslbw rhyslbw added this to the 3.0.0 milestone Aug 11, 2020
@rhyslbw rhyslbw self-assigned this Oct 20, 2020
@rhyslbw rhyslbw added in next release The issue is resolved, but not yet released and removed blocked labels Oct 20, 2020
@rhyslbw rhyslbw removed the in next release The issue is resolved, but not yet released label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants