Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute metadata for transaction #101

Closed
akegalj opened this issue Mar 21, 2019 · 1 comment
Closed

Compute metadata for transaction #101

akegalj opened this issue Mar 21, 2019 · 1 comment
Assignees

Comments

@akegalj
Copy link
Contributor

akegalj commented Mar 21, 2019

Context

A real wallet implementation may need to store more information than we have modelled in the specification so far. For instance, users may wish to know when their pending transactions got confirmed in the blockchain (as opposed to merely that they were confirmed), or what the effect was of a particular transaction on their balance (rather than merely being able to see the current balance).

Decision

Compute and maintain metadata for every transaction tracked by the wallet (transactions send to/from the wallet).

Acceptance Criteria

  1. Tx metadata must contain unique identifier (probably tx id)
  2. Tx metadata must contain depth (a.k.a "number of confirmations)
  3. Tx metadata must contain status: pending vs in-ledger vs invalidated
  4. Tx metadata must contain total amount
  5. Tx metadata must contain direction: outgoing vs incoming
  6. Tx metadata must contain timestamp when transaction was created
  7. Tx metadata must contain info about absolute slot & block number the transaction was inserted (from genesis)

Development Plan

PR

Number Base
#114 master

QA

@KtorZ
Copy link
Member

KtorZ commented Apr 2, 2019

This was done as part of #137 . This ticket is actually redundant with #90 so closing in favor of the latter.

@KtorZ KtorZ closed this as completed Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants