Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md: Tiny grammar mistake #1180

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

ubani
Copy link
Contributor

@ubani ubani commented Dec 20, 2023

fixed a typo

👋👋 Hello there! Welcome. Please follow the instruction below.

Click the Preview tab and select a PR template:

@rphair rphair added the typo Typographical error in documentation label Dec 20, 2023
@rphair rphair changed the title Update CONTRIBUTING.md CONTRIBUTING.md: Tiny grammar mistake Dec 20, 2023
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ubani you deserve the purple heart 💜 or bronze star ⭐ for disproportionate effort. 😜

Indeed I remember this typo (really a grammar mistake) and had to recall that it's not actually on the web site: intended I guess only to open in Markdown in a local source tree as per general standards. If anyone has seen this page linked in the site build (@katomm?), let me know since if so it might help to review for other grammar glitches & typos.

@ubani
Copy link
Contributor Author

ubani commented Dec 21, 2023

Hahaha, it was a flyby opportunity @rphair.
I was checking our version of your document as a template for the European Cardano Community and so it happened 🥳

@katomm
Copy link
Member

katomm commented Dec 22, 2023

@rphair CONTRIBUTING.md is an important standard repo file, but not part of the hosted site itself.
@ubani Good to see you here Marcus, what took you so long?😁

@rphair rphair merged commit 0cbbb44 into cardano-foundation:staging Dec 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typo Typographical error in documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants