Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close incremental decommit spec/impl gaps #1483

Closed
Tracked by #1057
ch1bo opened this issue Jul 8, 2024 · 2 comments · Fixed by #1491 or #1513
Closed
Tracked by #1057

Close incremental decommit spec/impl gaps #1483

ch1bo opened this issue Jul 8, 2024 · 2 comments · Fixed by #1491 or #1513
Assignees
Labels
task Subtask of a bigger feature.

Comments

@ch1bo
Copy link
Collaborator

ch1bo commented Jul 8, 2024

Why

Incremental decommit specification was updated by #1473 and we have a long-lived feature branch open which implements #1057 according to these spec changes. This item is to reconcile the implementation of the branch with the plan made in the specification, such that we have a working and consistent (maybe imperfect) state to be merged and maybe even released.

What

Clear red areas from #1473 by reviewing their coverage in #1344

  • Overall protocol life cycle and off-chain logic changes must be covered by integration and unit tests
  • Each change of on-chain code must be covered by a mutation test
  • Differences in implementation are to be resolved according to spec (if possible)
@ch1bo ch1bo mentioned this issue Jul 8, 2024
16 tasks
@ch1bo ch1bo added the task Subtask of a bigger feature. label Jul 8, 2024
@ch1bo ch1bo self-assigned this Jul 8, 2024
@ch1bo ch1bo linked a pull request Jul 10, 2024 that will close this issue
@ch1bo
Copy link
Collaborator Author

ch1bo commented Jul 11, 2024

Most major things I'm addressing of the (many) comments I left on #1344:

  • checkClose must not use version from redeemer
  • Close/Contest redeemer sum type
  • checkLastKnownVersion -> construct and observe correct version
  • Observe decrement outputs
  • Remove snapshot number check in close
  • Client request decommit: Check against local ledger -> inconsistent "user interface" logic
  • CloseTx chain layer interface -> remove redundancies / make invalid cases impossible
  • Maybe Hash vs. Maybe UTxO -> take a decision

@ch1bo ch1bo linked a pull request Jul 16, 2024 that will close this issue
4 tasks
@ch1bo
Copy link
Collaborator Author

ch1bo commented Jul 16, 2024

With #1513 ready to review, there is now only two things left to do:

  • Model versions in TxTrace
  • Move redundant / complex e2e tests (corner cases) into lower levels
  • Model spec concerns (comments)

@ch1bo ch1bo closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Subtask of a bigger feature.
Projects
None yet
1 participant