Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct labels in HF models config #13

Open
buhrmann opened this issue Jun 8, 2021 · 1 comment
Open

Add correct labels in HF models config #13

buhrmann opened this issue Jun 8, 2021 · 1 comment

Comments

@buhrmann
Copy link

buhrmann commented Jun 8, 2021

Just a suggestion, but e.g. here: https://huggingface.co/cardiffnlp/twitter-roberta-base-emoji/blob/main/config.json, if id2label and label2id were setup correctly, one wouldn't have to separately load the mappings.txt file from this github repo, and do the mapping manually.

@pedrada88
Copy link
Member

Thank you for the suggestion! For now, we will have to keep the same labels to be consistent (in case someone is already using the model and expects these labels instead of the correct ones).
In more recent models we did use the right labels without mapping.txt (for example the twitter-xlm-roberta-base-sentiment model - https://huggingface.co/cardiffnlp/twitter-xlm-roberta-base-sentiment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants