Skip to content

Commit

Permalink
Added some query logging, and tweaked the benchmarks.
Browse files Browse the repository at this point in the history
  • Loading branch information
@sam
sam committed Mar 26, 2008
1 parent 33c8998 commit 6e1c450
Show file tree
Hide file tree
Showing 2 changed files with 144 additions and 16 deletions.
9 changes: 7 additions & 2 deletions lib/data_mapper/adapters/data_objects_adapter.rb
View file
Expand Up @@ -67,7 +67,9 @@ def create(repository, instance)
properties = instance.class.properties(name).select { |property| dirty_attributes.key?(property.name) }

connection = create_connection
command = connection.create_command(create_statement(instance.class, properties))
sql = create_statement(instance.class, properties)
DataMapper.logger.debug { sql }
command = connection.create_command(sql)

values = properties.map { |property| dirty_attributes[property.name] }
result = command.execute_non_query(*values)
Expand All @@ -92,7 +94,9 @@ def read(repository, resource, key)
set = LoadedSet.new(repository, resource, properties_with_indexes)

connection = create_connection
command = connection.create_command(read_statement(resource, key))
sql = read_statement(resource, key)
DataMapper.logger.debug { sql }
command = connection.create_command(sql)
command.set_types(properties.map { |property| property.type })
reader = command.execute_reader(*key)
while(reader.next!)
Expand Down Expand Up @@ -161,6 +165,7 @@ def read_set(repository, query)
set = LoadedSet.new(repository, query.resource, properties_with_indexes)

sql = query_read_statement(query)
DataMapper.logger.debug { sql }

begin
connection = create_connection
Expand Down
151 changes: 137 additions & 14 deletions script/performance.rb
View file
Expand Up @@ -22,16 +22,21 @@

configuration_options[:socket] = socket_file unless socket_file.nil?

ActiveRecord::Base.establish_connection(configuration_options)
ActiveRecord::Base.logger = Logger.new(__DIR__.parent + 'log/ar.log')
ActiveRecord::Base.logger.level = 0

ActiveRecord::Base.find_by_sql('SELECT 1')
ActiveRecord::Base.establish_connection(configuration_options)

class ARExhibit < ActiveRecord::Base #:nodoc:
set_table_name 'exhibits'
end

ARExhibit.find_by_sql('SELECT 1')

require __DIR__.parent + 'lib/data_mapper'

DataMapper::Logger.new(__DIR__.parent + 'log/dm.log', :debug)

DataMapper.setup(:default, "mysql://root@localhost/data_mapper_1?socket=#{socket_file}")

class Exhibit
Expand All @@ -46,22 +51,140 @@ class Exhibit

end

Benchmark::bmbm(40) do |x|

x.report('ActiveRecord:id') do
1000.times { e = ARExhibit.find(1); e.id; e.name; e.created_on; e.updated_at; }
touch_attributes = lambda do |exhibits|
[*exhibits].each do |exhibit|
exhibit.id
exhibit.name
exhibit.created_on
exhibit.updated_at
end
end

# report_for_active_record = lambda do |runner, message, iterations, block|
# [:uncached, :cache].each do |variant|
# ActiveRecord::Base.send(variant) do
# runner.report(message + " #{(variant)}") do
# iterations.times do
# touch_attributes[block.call]
# end
# end
# end
# end
# end
#
# report_for_data_mapper = lambda do |runner, message, iterations, block|
# [:uncached, :cache].each do |variant|
# if variant == :cache
# repository(:default) { runner.report(message + " #{(variant)}", &block) }
# else
# runner.report(message + " #{(variant)}", &block)
# end
# end
# end

Benchmark::bmbm(60) do |x|

x.report('DataMapper:id') do
1000.times { e = Exhibit.get(1); e.id; e.name; e.created_on; e.updated_at; }
x.report('ActiveRecord:id x10_000') do
ActiveRecord::Base::uncached do
10_000.times { touch_attributes[ARExhibit.find(1)] }
end
end

x.report('ActiveRecord:all limit(100)') do
100.times { ARExhibit.find(:all, :limit => 100).map { |e| e.id; e.name; e.created_on; e.updated_at; } }

x.report('ActiveRecord:id(cached) x10_000') do
ActiveRecord::Base::cache do
10_000.times { touch_attributes[ARExhibit.find(1)] }
end
end

x.report('DataMapper:id x10_000') do
10_000.times { touch_attributes[Exhibit.get(1)] }
end

x.report('DataMapper:id(cached) x10_000') do
repository(:default) do
10_000.times { touch_attributes[Exhibit.get(1)] }
end
end

x.report('ActiveRecord:all limit(100) x1000') do
ActiveRecord::Base::uncached do
1000.times { touch_attributes[ARExhibit.find(:all, :limit => 100)] }
end
end

x.report('ActiveRecord:all limit(100) (cached) x1000') do
ActiveRecord::Base::cache do
1000.times { touch_attributes[ARExhibit.find(:all, :limit => 100)] }
end
end

x.report('DataMapper:all limit(100) x1000') do
1000.times { touch_attributes[Exhibit.all(:limit => 100)] }
end

x.report('DataMapper:all limit(100) (cached) x1000') do
repository(:default) do
1000.times { touch_attributes[Exhibit.all(:limit => 100)] }
end
end

x.report('DataMapper:all limit(100)') do
100.times { Exhibit.all(:limit => 100).map { |e| e.id; e.name; e.created_on; e.updated_at; } }
x.report('ActiveRecord:all limit(10,000) x10') do
ActiveRecord::Base::uncached do
10.times { touch_attributes[ARExhibit.find(:all, :limit => 10_000)] }
end
end

x.report('ActiveRecord:all limit(10,000) (cached) x10') do
ActiveRecord::Base::cache do
10.times { touch_attributes[ARExhibit.find(:all, :limit => 10_000)] }
end
end

x.report('DataMapper:all limit(10,000) x10') do
10.times { touch_attributes[Exhibit.all(:limit => 10_000)] }
end

x.report('DataMapper:all limit(10,000) (cached) x10') do
repository(:default) do
10.times { touch_attributes[Exhibit.all(:limit => 10_000)] }
end
end

end
end

__END__

On an iMac Core2Duo 2.16Ghz:

I don't think AR is actually caching.

~/src/dm-core > script/performance.rb
Text should not be declared inline.
Rehearsal -----------------------------------------------------------------------------------------------
ActiveRecord:id x10_000 3.490000 0.330000 3.820000 ( 4.766316)
ActiveRecord:id(cached) x10_000 3.500000 0.320000 3.820000 ( 4.763179)
DataMapper:id x10_000 3.770000 0.290000 4.060000 ( 5.036568)
DataMapper:id(cached) x10_000 3.380000 0.280000 3.660000 ( 4.626784)
ActiveRecord:all limit(100) x1000 12.490000 0.070000 12.560000 ( 13.244165)
ActiveRecord:all limit(100) (cached) x1000 12.520000 0.070000 12.590000 ( 13.147605)
DataMapper:all limit(100) x1000 9.900000 0.070000 9.970000 ( 10.925294)
DataMapper:all limit(100) (cached) x1000 7.740000 0.060000 7.800000 ( 8.532725)
ActiveRecord:all limit(10,000) x10 12.880000 0.080000 12.960000 ( 13.152890)
ActiveRecord:all limit(10,000) (cached) x10 12.950000 0.060000 13.010000 ( 13.187061)
DataMapper:all limit(10,000) x10 11.680000 0.060000 11.740000 ( 11.775914)
DataMapper:all limit(10,000) (cached) x10 8.980000 0.030000 9.010000 ( 9.063474)
------------------------------------------------------------------------------------ total: 105.000000sec

user system total real
ActiveRecord:id x10_000 3.460000 0.320000 3.780000 ( 4.696250)
ActiveRecord:id(cached) x10_000 3.460000 0.330000 3.790000 ( 4.704204)
DataMapper:id x10_000 3.770000 0.280000 4.050000 ( 4.997452)
DataMapper:id(cached) x10_000 3.400000 0.280000 3.680000 ( 4.617069)
ActiveRecord:all limit(100) x1000 12.050000 0.070000 12.120000 ( 12.702236)
ActiveRecord:all limit(100) (cached) x1000 12.040000 0.060000 12.100000 ( 12.664863)
DataMapper:all limit(100) x1000 9.490000 0.060000 9.550000 ( 10.112563)
DataMapper:all limit(100) (cached) x1000 7.310000 0.060000 7.370000 ( 7.921475)
ActiveRecord:all limit(10,000) x10 12.780000 0.040000 12.820000 ( 12.980122)
ActiveRecord:all limit(10,000) (cached) x10 12.820000 0.070000 12.890000 ( 13.077420)
DataMapper:all limit(10,000) x10 10.140000 0.030000 10.170000 ( 10.265600)
DataMapper:all limit(10,000) (cached) x10 7.570000 0.020000 7.590000 ( 7.601997)

0 comments on commit 6e1c450

Please sign in to comment.