Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When user logs in, new session should be started with editor closed #46

Open
dnaidionov opened this issue Mar 8, 2019 · 0 comments
Open

Comments

@dnaidionov
Copy link

Application remembers last state and, when user logs in, restores it. However, if users log in on the community page, or different article than they logged off from, they might be brought straight into the edit mode. We should start new session with closed editor, and edit mode off.
This was addressed in cardstack/dotbc#288 and cardstack/dotbc#284
However, I think we need to go deeper than this, and to turn off edit mode when user's session is terminated (either on log off or timeout) as leaving it might bring to unwanted side effects (e.g. user will continue seeing placeholders while being logged off)
Those are 3 related problems and will be tracked in 3 separate issues

This issue addresses starting new session with editor closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant