Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rules for categories per country/region to mark a category as closed rather than hiding it #291

Closed
caugner opened this issue Apr 10, 2020 · 6 comments
Labels
enhancement New feature or request priority: medium

Comments

@caugner
Copy link
Contributor

caugner commented Apr 10, 2020

Is your feature request related to a problem? Please describe.

  • When governments decide to open or close specific categories of places, right now the only option we have is to add or remove them from the map.
  • However, this may be surprising for users or even frustrating, because they cannot possibly know why the category of shop is closed (not everybody keeps track of the official rules).

Describe the solution you'd like

  • It would be helpful to mark a category as closed for a country or region.
  • Ideally these "region rules" would (optionally?) overwrite the individual taggings.

Describe alternatives you've considered
None considered.

Additional context
Background: bleibtoffen/bleibtoffen#30 (comment)

@caugner
Copy link
Contributor Author

caugner commented Apr 10, 2020

Actually, this feature could somewhat supersede the definition of categories per country.

Sure, there will always be some degree of customization with regard to adding specific categories (cf. chemist for DACH). However it would no longer be necessary to hide any category in any country (expect if that category is very very irrelvant), because "closed" categories could simply be "ruled out" (pun intended).

@caugner caugner changed the title Add rules for categories per country/region to mark a category as closed rather than hiding it them Add rules for categories per country/region to mark a category as closed rather than hiding it Apr 17, 2020
@PanierAvide
Copy link
Contributor

This might be done by extending categories.json, like having for each category and/or subcategory a property legalOpeningStatus with values like "FR": "open" or closed or no_visitors (= possible delivery/takeaway/contact by phone...).

@PanierAvide
Copy link
Contributor

This is now supported by legal_rules.csv in covid_enseignes : https://github.com/PanierAvide/Covid_enseignes#stores-and-services-legally-allowed-to-open-legal_rulescsv

Only thing left is make this CSV file used by caresteouvert map.

@PanierAvide
Copy link
Contributor

Note that this will allow to make ambiguous categories clearer when shown, but displaying all places from closed categories in this file would cause performance issues.

@georg-d
Copy link

georg-d commented Apr 29, 2020

Please consider to
a) use a base/background layer that shows "all" categories (yea, in reality, it will not be "all" but just "a lot")
and
b) load those closed categories "very lazy" (i.e. after the possibly open POIs and only when capacity exists, maybe only in very high zoom levels) and indicate via icon whether these categories have already been loaded or not yet.

Rationale: Multiple times, I was confused whether I am looking at the right part of the map because I know the position of several Corona-relevant shops only roughly, e.g. https://www.openstreetmap.org/node/3979040669 shop=clothes and https://www.openstreetmap.org/node/370637765 shop=outdoor selling masks and https://www.openstreetmap.org/node/3283156659 craft=tailor selling masks and material for sewing masks at home. Even after verifying the positions, because these shops do not show up at all, I can't provide the information they sell masks - which are hard to get in many parts of Germany despite/because they are now mandatory.

I am aware my examples are void when #558 is completely implemented but I strongly assume similar issues will happen again and again, because in all the cities/regions/countries together so many rules changes do happen that the website simply can't be always up to date.

@PanierAvide
Copy link
Contributor

There is now basic support of legal_rules.csv file (see https://github.com/PanierAvide/Covid_enseignes#stores-and-services-legally-allowed-to-open-legal_rulescsv ) to set which categories of POIs are closed per country. Places part of closed categories will appear as closed automatically as now (if category is listed on left sidebar).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: medium
Projects
None yet
Development

No branches or pull requests

3 participants