Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MultiFetcher smarter #372

Closed
NobodyXu opened this issue Sep 10, 2022 · 1 comment · Fixed by #382
Closed

Make MultiFetcher smarter #372

NobodyXu opened this issue Sep 10, 2022 · 1 comment · Fixed by #382
Labels
Report: bug Something isn't working Report: enhancement Request for improvements to existing features or code

Comments

@NobodyXu
Copy link
Member

From #370 (comment) :

That sounds like we should use smarer MultiFetcher which download the archive and verify that it contains all command we need.
@NobodyXu NobodyXu added Report: bug Something isn't working Report: enhancement Request for improvements to existing features or code labels Sep 10, 2022
@passcod
Copy link
Member

passcod commented Sep 11, 2022 •
edited

I think that's getting quite specific and convoluted. Nevertheless, in the interest of time, I have half a PR for a fix... needs more work, but I'll push it so we don't both work on the same thing at cross purposes: #373

@NobodyXu NobodyXu mentioned this issue Sep 14, 2022
Merged
@passcod passcod mentioned this issue Sep 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Report: bug Something isn't working Report: enhancement Request for improvements to existing features or code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Verify that bin_files exist in resolve stage cargo-bins/cargo-binstall
2 participants
@passcod @NobodyXu