New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for releasing all crates in the workspace #53
Comments
Sure, we'd need to add a flag to do that, and I'd accept a PR for it. To help with that, the flag would:
|
Not related to this but note that this action has no yet been updated to take advantage of the new cargo-release modes for split releases. |
Thanks for the pointers! I've started making some changes, but it turns out to be more involved than I initially envisioned.
Then branch name, PR template and semver checks are all affected. Let me know whether you'd prefer a full-fledged solution to take care of all the scenarios, or whether you're ok to start off with a limited feature set. Then we should still decide what to do about semver checks and PR template (maybe skip the checks for multiple crates, and have a slightly adapted PR template for all crates?) |
Yeah, disallowing bump versions when this option is provided is a good start, though there could be some detection that all the versions in the workspace are the same, and so bumping will result in the same output version everywhere (and check that after running cargo-release, too, just in case). But happy with a simple disallow for now. (If there's different versions across the workspace, it should always disallow, and in fact I would go further and fail the entire run if I think the checks should still run for multiple crates, if possible to do easily. |
I think I've got a working action now, I've tested on a fork of |
Works like a charm for my fork of arkworks-algebra, see example here. There I'm using my own fork of |
For projects with a large number of crates per repository, it would be very useful to have an option to run
cargo release
from workspace root, so that the version for each crate is bumped consistently across the repo (this also helps with tag management, since we don't want to have a separate tag for each single crate).Do you think this is something that could be supported by
release-pr
action? It'd then fit my usecase quite well.The text was updated successfully, but these errors were encountered: