Use a single definition per tag name #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when imported.
The main index file behaves the same so this is backwards compatible.
I'm working on using this library at google, and I want to make sure we only use it in development (using a technique similar to `if (process.env === 'dev') { activate() }`). We also patch HTMLElement in the custom elements es5 shim, and we need to apply that patch before we apply this one, and exporting the activate function makes it somewhat easier to ensure that the patches are applied in the correct order.
…cted with new We need to use the constructor call trick in the PivotCtor when the element has been created by the browser directly (e.g. document.createElement, or via the parser) because in that case the only constructor that's called is the PivotCtor. However, if the element is called via `new MyElement()` then the MyElement constructor (and any superclass constructors) will be called properly without any work on our part. This change fixes a bug we noticed where calling `new MyElement()` was running constructors twice.
Update it when the tag is redefined. This way LatestCtor and the callbacks are updated for all instances immediately on redefinition. I'm not certain this change is an improvement in all cases, but it's the behavior that I think we generally want when doing HMR in google, but I could see the value in making it an option.
|
@rictic thanks for the PR, but it is impossible to review... can you update the PR with the actual changes? The diff, even when ignoring the whitespaces, it is the entire file. |
|
This builds on top of #3 to make it easier to merge them both, if you look at just the second and third commits the change is clearer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update it when the tag is redefined.
This way LatestCtor and the callbacks are updated for all instances immediately on redefinition.
I'm not certain this change is an improvement in all cases, but it's the behavior that I think we generally want when doing HMR in google, but I could see the value in making it an option.