fix bug for delete lv when node is not ready #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carina-ci-bot
added
size/M
approved
|
/ok-to-test |
carina-ci-bot
added
the
ok-to-test
|
/assign @fanhaouu |
fanhaouu
reviewed
Sep 16, 2022
controllers/node_controller.go
Outdated
| @@ -191,6 +192,12 @@ func (r *NodeReconciler) getNeedRebuildVolume(ctx context.Context) (map[string]c | |||
| continue | |||
| } | |||
|
|
|||
| log.Infof("checkouk lv: %s", lv.Name) | |||
| if isSkip, err := r.skipLv(ctx, lv); isSkip || err != nil { | |||
| log.Errorf("skip lv Whether the pod.annotation meets the condition in not ready node:%s err:%s", lv.Spec.NodeName, err.Error()) | |||
There was a problem hiding this comment.
there is a extra space after the condition word
There was a problem hiding this comment.
@zhangkai8048 Is the checkout word wrong ?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fanhaouu, zhangkai8048 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #128
Special notes for your reviewer:
Does this PR introduce a user-facing change?: