Memory Leak

[pjebs]

if I have removeOnCompletion=true,

when the animation finishes it does remove itself from the superview but something else is holding a strong reference to JRMFloatingAnimationView hence it never deallocates.

Perhaps (not tested) the FloatingImageView deallocs but not the AnimationView.

[pjebs]

Forget what I wrote. I misunderstood the difference between JRMFloatingAnimationView and JRMFloatingImageView.

[pjebs]

Actually to solve the issue this change should be made:

There are numerous blocks inside JRMFloatingImageView that keep a strong reference to self.
I am using your control for a 'non-standard' use case and self is dangling at times.

You should use:
__weak typeof(self) weakSelf = self;
and use weakSelf inside the blocks instead of self.

There is no harm in doing that anyway.

[pjebs]

since I didn't want to interfere with your code (cocoapods), I had to subclass. Here is my modifications that may be helpful for eccentric use cases:

It would be good if you could implement these changes so I can get rid of my subclass. I also couldn't access some stuff so I had to use a work around:

Header:

[pjebs]

FloatingAnimationView.h.txt
FloatingAnimationView.m.txt

[pjebs]

https://github.com/nathanwhy/HYBubbleButton

[carleihar]

@pjebs Were you experiencing an EXC_BAD_ACCESS crash? Setting the delegate to (nonatomic, weak) instead of (nonatomic, assign) will fix this if using ARC. Without this fix, the delegate will not be set to nil when it is deallocated and then will crash on animationDidStop. I will fix this and push it this week.

[carleihar]

@pjebs This is fixed in version 0.1.1.

[Xedart]

I don't know if this project is still alive but I still have this issue :) FloatingImageView does not remove itself from JRMFloatingAnimationView upon animation completion. They just still there, and if I add new ones, they are collected until app runs out of memory.

[Xedart]

Was able to solve my problem by changing
pathAnimation.removedOnCompletion = NO;
to
pathAnimation.removedOnCompletion = YES;
in JRMFloatingImageView' start method. I am not sure what kind of problem it was, and if it was unique to my use case, but maybe it will be helpful to somebody :)

[bishalg]

the issue is if the view controller disappears,
there is the sudden memory leak and CPU usage start to climb up then again if we are back to VC the issue is resolved.

If only there was the option to stop() animation it would have been the way to stop the leak.
Even if we manually remove the animation it will again trigger the leak!