Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol #3

Closed
pjebs opened this issue Apr 17, 2016 · 1 comment
Closed

protocol #3

pjebs opened this issue Apr 17, 2016 · 1 comment

Comments

@pjebs
Copy link

pjebs commented Apr 17, 2016

I tried to implement your JRMBubbleTutorial using JRMFloatingImageView class.
Unfortunately it's not easy to do because the delegate is specified to be of type JRMFloatingAnimationView rather than the JRMFloatingImageViewDelegate protocol.

If you had added the synthesized property methods as part of the protocol, it would have been more idiomatic and reusable.

@carleihar
Copy link
Owner

carleihar commented Apr 18, 2016

@pjebs You shouldn't be using The FloatingImageView class to do something like the JRMBubbleTutorial. Have you looked at the tractor demo for JRMFloatingAnimation? That is exactly how you would do it, just using a fish image view instead of a tractor:

https://gist.github.com/carleihar/31d5828773fed8144a15abb805a0ff8c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants