Add Coveralls support #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coveralls doesn't work with Python 2.5 so it can't be tested
|
Changes Unknown when pulling 6a144e3 on treyhunner:coveralls into * on carljm:master*. |
|
Changes Unknown when pulling 732278a on treyhunner:coveralls into * on carljm:master*. |
|
This looks great! Merge away :-) |
|
Not sure what "changes unknown" means - maybe that's a feature that needs a prior build with coverage before it'll work? |
|
I think that's what it means. Hopefully anyone that cares about code coverage knows 100% coverage doesn't mean "no bugs". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the coveralls badge in django-widget-tweaks. Seems like a code coverage badge probably wouldn't hurt.
I removed Python 2.5 support from Travis tests because coveralls can't be used otherwise. The tox file doesn't test 2.5 anyways so support was basically already dropped previously.
I also think adding the
?branch=masterat the end of the Travis badge may fix the weird oddity we saw earlier with an old commit from a pushed tag messing up the build status.