Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StatusField and MonitorField bugs #38

Merged
merged 1 commit into from Apr 9, 2013
Merged

Fix StatusField and MonitorField bugs #38

merged 1 commit into from Apr 9, 2013

Conversation

treyhunner
Copy link
Member

This should fix #29.

Tests pass for me in Python 3 with this change.

@carljm
Copy link
Collaborator

carljm commented Apr 9, 2013

StatusField changes look good. The MonitorField changes are ok I guess, but I don't think they are necessary; the MonitorField contribute_to_class doesn't do anything that depends on having the class fully prepared, it just registers a post_init signal (and that signal won't ever fire until after the class is prepared anyway).

@treyhunner
Copy link
Member Author

@carljm you're right. I'm not sure why I thought MonitorField was causing an issue. I removed that change and am merging the fix for StatusField now.

treyhunner added a commit that referenced this pull request Apr 9, 2013
@treyhunner
Merge pull request #38 from carljm/fix-statusfield
e1395c6 
Fix StatusField and MonitorField bugs
@treyhunner treyhunner merged commit e1395c6 into master Apr 9, 2013
@treyhunner treyhunner deleted the fix-statusfield branch April 9, 2013 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AssertionError: To use StatusField, the model 'MyModel' must have a STATUS choices class attribute.
2 participants
@treyhunner @carljm