Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to make sure get_subclass() is on QuerySet #82

Merged
merged 2 commits into from
Oct 8, 2013

Conversation

tswicegood
Copy link
Contributor

There's an edge case where you might want to call get_subclass() on a
QuerySet the same way you can call get() after you have already called
various filter/exclude methods.

There's an edge case where you might want to call get_subclass() on a
QuerySet the same way you can call get() after you have already called
various filter/exclude methods.
@carljm
Copy link
Collaborator

carljm commented Oct 7, 2013

Thanks Travis! Any chance you'd be willing to add a test for using get_subclass on a QuerySet?

@tswicegood
Copy link
Contributor Author

Not sure when I'll be able to get to it. I'm assuming there's a few tests for get_class so I could just copy those. I did verify that the py2.7-1.5 environment does still pass.

@tswicegood
Copy link
Contributor Author

@carljm Added a test that verifies that all().get_subclass() chained works. Not a direct test on the QuerySet, but does fail against master.

@carljm
Copy link
Collaborator

carljm commented Oct 8, 2013

Looks great, thanks!

carljm added a commit that referenced this pull request Oct 8, 2013
Refactor to make sure get_subclass() is on QuerySet
@carljm carljm merged commit 12906a1 into jazzband:master Oct 8, 2013
@tswicegood tswicegood deleted the fix-get_subclass branch October 10, 2013 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants