fix/windows-crash: fix crash due to unwrap on Windows #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We run into cases every now and then when the remote address returned by miow crate is None. This usually happens during severing of connection and hence we are no longer interested in the remote address anyway. However mio crate tries to unwrap the returned option crashing in several of our usages (esp. when stressed). This fix aims to prevents that crash.
Closed
I was compiling Windows fix on Linux (which is why it built successfully) and never noticed the unneeded semicolon :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run into cases every now and then when the remote address returned by miow crate is None. This usually happens during severing of connection and hence we are no longer interested in the remote address anyway. However mio crate tries to unwrap the returned option crashing in several of our usages (esp. when stressed). This fix aims to prevent that crash.