Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Axies not showing on cards #6

Merged
merged 2 commits into from Oct 10, 2021
Merged

Conversation

sushiAlii
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Oct 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carlomigueldy/supa/HU64Bj4wxZgLAwQ8DqRmZuofLRmJ
✅ Preview: https://supa-git-feature-scholar-profile-carlomigueldy.vercel.app

@@ -114,6 +114,8 @@ export default {
methods: {
async getUserAxies(wallet) {
try {
var splitAddress = wallet.split("ronin:");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor this to

const wallet = `0x${this.$stringUtil.extractRoninAddress(wallet)}`

Copy link
Owner

@carlomigueldy carlomigueldy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlomigueldy carlomigueldy merged commit faeafc4 into main Oct 10, 2021
@carlomigueldy carlomigueldy deleted the feature/scholar-profile branch October 10, 2021 15:22
@sushiAlii sushiAlii restored the feature/scholar-profile branch October 10, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants