Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentinel Auto Discovery #38

Open
heynemann opened this issue Apr 5, 2018 · 2 comments
Open

Sentinel Auto Discovery #38

heynemann opened this issue Apr 5, 2018 · 2 comments

Comments

@heynemann
Copy link

I know it states in the docs that the sentinel support is not intended for auto-discovery of redis hosts, but since many other clients do it, it would be a great addition to this already incredible vmod.

Do you think it is something you'd be willing to implement? I wish I could help with a PR, but my C skills are rusty.

Thank you so much for this awesome vmod!

@carlosabalde
Copy link
Owner

Thanks for using the VMOD @heynemann :) I'd need to check it again, but I'm afraid is not trivial to support that use case due to some previous design decisions. I'll add this to my personal TODO list and revisit it as soon as I have some spare time available.

You can also consider contacting https://allenta.com if you are using the VMOD in a commercial context and your company is open to sponsor this feature. That would help to get things done faster :)

@heynemann
Copy link
Author

Thanks!!! :) I'm going to discuss here at Globo.com if it is feasible to support this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants