Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace BaseModel class with an interface or a trait #11

Closed
carlosafonso opened this issue Mar 21, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@carlosafonso
Copy link
Owner

commented Mar 21, 2016

Having a BaseModel class is pretty ugly. It forces developers to make all their models extend this class, forcing them to commit to a class hierarchy and limiting their design choices.

The current purpose of BaseModel is to define the getValidationRules() function, which is used by CrudController. This purpose should be accomplished with a different solution, such as an interface or a trait.

Thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.