Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace BaseModel class with an interface or a trait #11

Closed
carlosafonso opened this issue Mar 21, 2016 · 0 comments
Closed

Replace BaseModel class with an interface or a trait #11

carlosafonso opened this issue Mar 21, 2016 · 0 comments
Labels
enhancement
Milestone
0.1.0

Comments

@carlosafonso
Copy link
Owner

Having a BaseModel class is pretty ugly. It forces developers to make all their models extend this class, forcing them to commit to a class hierarchy and limiting their design choices.

The current purpose of BaseModel is to define the getValidationRules() function, which is used by CrudController. This purpose should be accomplished with a different solution, such as an interface or a trait.

Thoughts on this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
2 participants
@namelivia @carlosafonso