Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responses being wrapped in a opaque class #2

Closed
carlosalberto opened this issue May 17, 2017 · 1 comment
Closed

Responses being wrapped in a opaque class #2

carlosalberto opened this issue May 17, 2017 · 1 comment

Comments

@carlosalberto
Copy link
Owner

(This is a potential improvement)

Right now Responses is of type BlockingCollection - which means that the user can read and write to it. We should probably offer an opaque interface, i.e. so the users can't add objects there.

Observe that BlockingCollection implements IReadOnlyCollection, but that interface doesn't offer the nice TryTake method.

We could still offer other common interfaces, such as ICollection (as BlockingCollection as of now does).
@carlosalberto
Copy link
Owner Author

Fixed as part of 1865fc7. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carlosalberto