Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in classes should not be ignored when specifically requested in rules #221

Open
carlosas opened this issue Jun 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@carlosas
Copy link
Owner

When the option ignore_built_in_classes is enabled, and there is a rule like:

return PHPat::rule()
  ->classes(Selector::namespace('App\Whatever'))
  ->shouldImplement()
  ->classes(Selector::classname(\JsonSerializable::class));

PHPat reports:

App\Whatever\MyClass should implement JsonSerializable


Built-in classes should be removed from the violations, instead of the nodes to be checked.

@carlosas carlosas added the bug Something isn't working label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant