Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect dependency versions specified are causing warnings #801

Closed
mikesprague opened this issue Mar 21, 2022 · 2 comments
Closed

Incorrect dependency versions specified are causing warnings #801

mikesprague opened this issue Mar 21, 2022 · 2 comments
Labels

Comments

@mikesprague
Copy link

mikesprague commented Mar 21, 2022

Hello @carloscuesta!

Issue:

When upgrading my global install to the latest version (npm i -g gitmoji-cli) I received some dependency and peer dependency warnings about the versions requested. This has happened everywhere I use it so far (MacOS, Ubuntu via WSL2, and inside of GitHub Codespaces).

OS: MacOS (and Ubuntu via WSL2)
gitmoji -v: 4.10.0
Node version: v17.7.2 (and v16.14.2)

Error Message:

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: inquirer-autocomplete-prompt@1.0.1
npm WARN Found: inquirer@8.1.1
npm WARN node_modules/gitmoji-cli/node_modules/inquirer
npm WARN   inquirer@"8.1.1" from gitmoji-cli@4.10.0
npm WARN   node_modules/gitmoji-cli
npm WARN     gitmoji-cli@"*" from the root project
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer inquirer@"^5.0.0 || ^6.0.0" from inquirer-autocomplete-prompt@1.0.1
npm WARN node_modules/gitmoji-cli/node_modules/inquirer-autocomplete-prompt
npm WARN   inquirer-autocomplete-prompt@"1.0.1" from gitmoji-cli@4.10.0
npm WARN   node_modules/gitmoji-cli
npm WARN
npm WARN Conflicting peer dependency: inquirer@6.5.2
npm WARN node_modules/inquirer
npm WARN   peer inquirer@"^5.0.0 || ^6.0.0" from inquirer-autocomplete-prompt@1.0.1
npm WARN   node_modules/gitmoji-cli/node_modules/inquirer-autocomplete-prompt
npm WARN     inquirer-autocomplete-prompt@"1.0.1" from gitmoji-cli@4.10.0
npm WARN     node_modules/gitmoji-cli

Screen Shot 2022-03-21 at 9 50 12 AM

Please let me know if there's any additional information that would be useful. Thanks!

@carloscuesta
Copy link
Owner

Hey @mikesprague thanks for opening the issue,

You can ignore the warning, the cli should work in the same way as of now, I opened a PR to update the dependency so the warning doesn't appears anymore when installing the cli.

Will publish an update soon 😊

@carloscuesta
Copy link
Owner

carloscuesta commented Mar 21, 2022

Fixed and published in 4.11.0 🙏🏼

Screen Shot 2022-03-21 at 18 22 41

https://github.com/carloscuesta/gitmoji-cli/releases/tag/v4.11.0

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants