Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add :hover animation on emoji and code #670

Closed
johannchopin opened this issue Dec 30, 2020 · 3 comments · Fixed by #671
Closed

✨ Add :hover animation on emoji and code #670

johannchopin opened this issue Dec 30, 2020 · 3 comments · Fixed by #671
Assignees
@johannchopin
Labels
improvement Website improvements
Projects
Gitmoji Kanban

Comments

@johannchopin
Copy link
Collaborator

Hello @carloscuesta 😎!

New website don't has the previous animations when you over a gitmoji emoji or code.
@johannchopin johannchopin self-assigned this Dec 30, 2020
@carloscuesta
Copy link
Owner

Yes! Animations got removed when I implemented dark mode and switched from SCSS to CSS in JS. I noted that this was pending but got lost!

Thanks for opening the issue

@carloscuesta carloscuesta added this to To do in Gitmoji Kanban via automation Dec 30, 2020
@carloscuesta carloscuesta moved this from To do to In progress in Gitmoji Kanban Dec 30, 2020
@carloscuesta carloscuesta added the improvement Website improvements label Dec 30, 2020
@carloscuesta
Copy link
Owner

Will you work on this @johannchopin ?

@johannchopin
Copy link
Collaborator Author

johannchopin commented Dec 30, 2020 •
edited

@carloscuesta yes I assigned this issue to myself so I will do it asap 👍

@johannchopin johannchopin mentioned this issue Dec 30, 2020
Merged
1 task
Gitmoji Kanban automation moved this from In progress to Done Jan 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@johannchopin johannchopin

Labels
improvement Website improvements
Projects
Gitmoji Kanban
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🩹 Fix missing animations johannchopin/gitmoji
2 participants
@carloscuesta @johannchopin