You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
I recently noticed that Gitmoji is using the simple fetching strategy and I would suggest using something better instead. In Next.js, as we have the getStaticProps method, if we use that method, it fetches the data at build time and the data is ready there so our page is no longer loading images.
So whenever a PR is merged, the data is fetched by getStaticProps and the contributors page is ready to view with all the contributors quickly.
I made the change on gitmoji locally, it worked out very well with no issues. But the tests are coming my way. I am not familiar with testing. I tried every possible way to push the changes and make a PR but the tests are stopping me so we will need to change the tests.
To Reproduce
Steps to reproduce the behavior:
Fix the tests for the component.
Expected behavior
The tests should pass successfully.
Screenshots
The text was updated successfully, but these errors were encountered:
Describe the bug
I recently noticed that Gitmoji is using the simple fetching strategy and I would suggest using something better instead. In Next.js, as we have the
getStaticProps
method, if we use that method, it fetches the data at build time and the data is ready there so our page is no longer loading images.So whenever a PR is merged, the data is fetched by
getStaticProps
and the contributors page is ready to view with all the contributors quickly.I made the change on gitmoji locally, it worked out very well with no issues. But the tests are coming my way. I am not familiar with testing. I tried every possible way to push the changes and make a PR but the tests are stopping me so we will need to change the tests.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The tests should pass successfully.
Screenshots
The text was updated successfully, but these errors were encountered: