Popup style #32
Merged
Popup style #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnFTitor
reviewed
Feb 2, 2022
Comment on lines
+69
to
+71
| @media (min-width: 768px) { | ||
| height: 77px; | ||
| width: 77px; |
There was a problem hiding this comment.
[OPTIONAL] It would be better to create a mixing for this media query to keep consistency and enhance readability
JohnFTitor
approved these changes
Feb 2, 2022
There was a problem hiding this comment.
Hi @carloshs1994 👋🏻
I only have one tiny suggestion. Aside from it, I think everything is fine with this PR 🎉 🎉
You've done a great job so far! Let's highlight the best approaches within this project:
- ✅ Add strong style to property names.
- ✅ Add box shadows to buttons and a good effect.
Keep up the good pace! 😸
Cheers and Happy coding!👏👏👏
This is a feature teammate review. Remember that everything said here is intended for both of us to learn and grow as Software Developers 💻 and we may have different approaches or perspectives. That being said, don't hesitate to comment if you disagree with one required change. We can talk everything through 🐱
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @JohnFTitor 👋🏻
Thanks for taking the time to review the project. Here are some things important to note about it:
Sass
The project was built using Sass. The only difference was that we needed to add an additional loader to webpack, but the result is overall the same (A CSS output). Additionally, we used
MiniCssExtractPluginto generate an external CSS file in the dist folder instead of the styles in the head of the document. It has the same dynamic response, it's just that the output looks more organized.Now into the project...
Changes implemented in "popup-style" branch
Final notes
Is expected that this project meets the requirements. Please let us know if anything is left to be done or can be improved. Again, thanks for the review.