You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The name of the commentCounter function does do not reflect its functionality, because it gets from the very beginning the value that it is supposed to return, in this case, the length of the comment array. What it is actually doing is checking that the length of the comment array is valid.
Suggestion
To fix this issue I would recommend that in the commentCounter function put as a parameter the array of comments, and then return the length of the array.
The text was updated successfully, but these errors were encountered:
Excellent and beautiful project guys! I only have one minor issue.
Issue
choose-your-pokemon/src/scripts/modules/comments.js
Lines 23 to 26 in 7ffcf1d
The name of the
commentCounter
function does do not reflect its functionality, because it gets from the very beginning the value that it is supposed to return, in this case, the length of the comment array. What it is actually doing is checking that the length of the comment array is valid.Suggestion
To fix this issue I would recommend that in the
commentCounter
function put as a parameter the array of comments, and then return the length of the array.The text was updated successfully, but these errors were encountered: