Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style refactor #52

Merged
merged 5 commits into from Jun 17, 2022
Merged

Style refactor #52

merged 5 commits into from Jun 17, 2022

Conversation

JohnFTitor
Copy link
Collaborator

Hi there, @carloshs1994

Thanks for taking the time to review the project

I was stepping by and thought about refactoring the color scheme we previously chose for the project. I've been learning a bit about material guidelines for these colors and thought about giving it a try here. Please let me know what you think!

Sass

The project was built using Sass. The only difference was that we needed to add an additional loader to webpack, but the result is overall the same (A CSS output). Additionally, we used MiniCssExtractPlugin to generate an external CSS file in the dist folder instead of the styles in the head of the document. It has the same dynamic response, it's just that the output looks more organized.

Now into the project...

Changes implemented in "Style Refactor" branch

  • ✅ This PR solves [1pt] Refactor Styling #51
  • ✅ Included new color scheme in _variables.scss
  • ✅ Applied new color scheme to webpage

Final notes

Is expected that this project meets the requirements. Please let me know if anything is left to be done or can be improved. Again, thanks for the review.

@JohnFTitor JohnFTitor added the enhancement New feature or request label Apr 29, 2022
@JohnFTitor JohnFTitor self-assigned this Apr 29, 2022
- Add new previews to README.md
@JohnFTitor JohnFTitor merged commit ef739ea into development Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Code them all
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

1 participant