Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .Net Framework requirements to support framework 4.7 #31

Closed
jesuissur opened this issue Nov 6, 2017 · 6 comments
Closed

Update .Net Framework requirements to support framework 4.7 #31

jesuissur opened this issue Nov 6, 2017 · 6 comments

Comments

@jesuissur
Copy link
Contributor

Hi there

We've installed the latest EAP (2017.2) and the plugin stopped working because it depends on a framework that is installed on the agent but does not exists as agent configuration.

It would be nice to update the requirement as the first one in the image

image

@carlpett
Copy link
Owner

Hi,
Thanks for the report, and sorry for the slow response. I'll fix this, good catch!

@carlpett
Copy link
Owner

When looking a bit closer, it wasn't exactly as simple as I had thought (the requirement is set dynamically depending on the selected runtime for xUnit). What frameworks does your agent report that is has? I

@jesuissur
Copy link
Contributor Author

jesuissur commented Nov 13, 2017

Hi

I've made the following change locally and it works on my case. Not sure it is the best practice on the code base so I did not made a pull request

xunit-server\src\main\java\se\capeit\dev\xunittestrunner\XUnitTestRunType.java
before:
else if (runtime.equals(Runtime.dotNET45)) { frameworkMatcher = "4.[56](\\.[0-9]+)?"; // Match 4.5+ }
after:
else if (runtime.equals(Runtime.dotNET45)) { frameworkMatcher = "4.[5-9](\\.[0-9]+)?"; // Match 4.5+ }

Those are my agent parameters about .Net
image

Thanks
Phil

@carlpett
Copy link
Owner

Hi,
That looks like the exact right change, so a PR for that would be great!
Apparently my agents are a bit outdated, I'll need to have a look at that. Thanks for the image!

jesuissur added a commit to jesuissur/xUnit-TeamCity that referenced this issue Nov 13, 2017
@jesuissur
Copy link
Contributor Author

Pull Request #32

carlpett added a commit that referenced this issue Nov 14, 2017
#31 Update .Net Framework requirements to support framework 4.7
@carlpett
Copy link
Owner

Thanks a lot! I've merged it, will make a new release in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants