Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The JavaParser has the wrong type definition for the dimNames map #23

Closed
chrisco484 opened this issue Nov 8, 2020 · 1 comment
Closed

Comments

@chrisco484
Copy link

chrisco484 commented Nov 8, 2020

Currently the map is declared with:

public Map<String, String> dimNames = new HashMap<String, String>();

but that won't compile because the code needs to store a map keyed on String but with a List of Strings being the value type. So this is the correct declaration:

Map<String, List<String>> dimNames = new HashMap<>();

Nice list - what is the best way for suggesting new aliases/nicknames?

@carltonnorthern
Copy link
Owner

Thanks! I've been fairly hands-off with this project for a while. A pull request for both this issue, and for suggesting additions would be great appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants