Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose functions for validation #4

Open
pbotros opened this issue Dec 21, 2021 · 1 comment
Open

Expose functions for validation #4

pbotros opened this issue Dec 21, 2021 · 1 comment

Comments

@pbotros
Copy link
Collaborator

pbotros commented Dec 21, 2021

From #3:

Another question is that could you please provide some interface like '_assert_decomp_successful' at https://github.com/carmenalab/emgdecomp/blob/master/emgdecomp/tests/test_decomposition.py#L140 for validation?

cc @shihan-ma

@pbotros
Copy link
Collaborator Author

pbotros commented Dec 21, 2021

It's a good point to expose! I bet people will often do their own validations with their own simulated data. I'll look into it, but in the meantime, copy/pasting the contents of that _assert_decomp_successful function into your own code is an acceptable hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant